Skip to content

fix: aspectRatio type in schema#2089

Merged
antfu merged 7 commits into
slidevjs:mainfrom
jpoehnelt:main
Mar 31, 2025
Merged

fix: aspectRatio type in schema#2089
antfu merged 7 commits into
slidevjs:mainfrom
jpoehnelt:main

Conversation

@jpoehnelt

@jpoehnelt jpoehnelt commented Feb 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor 
Incorrect type. Expected "number".yaml-schema: 
file:///.../antfu.slidev-51.3.0/schema/headmatter.json
Aspect ratio for slides should be like 16/9 or 1:1

@netlify

netlify Bot commented Feb 25, 2025 •
edited
Loading

Copy link
Copy Markdown

❌ Deploy Preview for slidev failed.

Name Link
🔨 Latest commit a0904d7
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/67ea1d8b8eea7f0008759469

kermanx
kermanx requested changes Mar 4, 2025
View reviewed changes

@kermanx kermanx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that

slidev/packages/parser/src/config.ts

Line 95 in dd883b7

config.aspectRatio = parseAspectRatio(config.aspectRatio)
has normalized the value. All the additions of parseAspectRatio in this PR seem to be unnecessary. Correct me if I am wrong

@pkg-pr-new

pkg-pr-new Bot commented Mar 31, 2025 •
edited
Loading

Copy link
Copy Markdown

Open in Stackblitz

@slidev/client

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/client@2089

create-slidev

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev@2089

create-slidev-theme

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@2089

@slidev/parser

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/parser@2089

@slidev/cli

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/cli@2089

@slidev/types

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/types@2089

commit: a0904d7

@antfu
antfu merged commit dc8b462 into slidevjs:main Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kermanx kermanx kermanx requested changes
@antfu antfu antfu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpoehnelt @antfu @kermanx