fix: clear idle cursor timeout when disabling the option or changing to the presenter mode#2147
Merged
Conversation
❌ Deploy Preview for slidev failed.
|
antfu
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2146
With this change the timer gets cleared in two scenarios:
shouldHideenabled. Before the change the timer started in the play mode would finish after switching to the presenter mode and the cursor got stuck in the hidden mode indefinitely.shouldHideis disabled via keyboard. In this scenario the pointer event listener isn't called, so the cursor would hide after disabling the option—this happened only once per toggle, though.