fix: add optional chain to prevent nullish broken#2208
Merged
kermanx merged 1 commit intoJun 22, 2025
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kermanx
approved these changes
Jun 22, 2025
kermanx
approved these changes
Jun 22, 2025
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have encountered this issue in my own PPT project (which can be a reproduction repo): https://github.com/ShenQingchuan/vue-vine-ppt-2025
But it'll be OK after restarting the slidev dev server.
I think it might be caused by my Vue Vine plugin using in setup/main.ts, maybe it's applied before Vue Router and the router instance was not initialized at that moment? I'm not quite sure ...
But I've tried and approved that this line of change works as expected, which is adding optional chain operators.
fix #2047