fix: make useIsSlideActive() based on useSlideContext().$nav.currentSlideNo instead of useNav().currentSlideNo#2311
Merged
antfu merged 2 commits intoOct 22, 2025
Conversation
…lideNo instead of useNav().currentSlideNo Because useNav().currentSlideNo is just a value parsed from the URL route but useSlideContext().$nav.currentSlideNo is a more controlled value that even works in print/export mode.
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
whitphx
marked this pull request as ready for review
October 22, 2025 05:18
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because useNav().currentSlideNo is just a value parsed from the URL route but useSlideContext().$nav.currentSlideNo is a more controlled value that even works in print/export mode.
Fixes #2310
Let me create this PR before the discussion in #2310 is settled just for dumping and proposing my current idea. Plz decline it if it's not appropriate.