fix: resolver should prioritize prefixed addons/themes again#2398
Merged
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the logic for resolving addons and themes was selecting the package that looked like
slidev-{type}-{name}or@slidev/{type}-{name}and falling back to{name}if not found, so users can specifyxyzto use for instance an addon calledslidev-addon-xyz.But in c53794b this behavior was changed to first check
{name}over the others.I have an extension called
slidev-addon-tldrawthat is dependent ontldraw. Since that change, thetldrawpackage is mistakenly loaded as addon, which is a no-op, but breaks the expected addon behavior.This PR reverts to the old prioritization behavior as I think this is an unwanted regression.