Fix strError() to report the requested errno, not the global one#811
Open
MarkRose wants to merge 1 commit into
Open
Fix strError() to report the requested errno, not the global one#811MarkRose wants to merge 1 commit into
MarkRose wants to merge 1 commit into
Conversation
- strError(int errnum) in src/misc/common.h took an explicit error number argument but ignored it, calling strerror_r() with the global errno instead. Any caller that saves an errno value (e.g. after a failed syscall, once other code may have run and changed the global errno) and then calls strError(saved_errno) would get the message for whatever errno currently holds, not the one it asked about. Fixed by passing errnum through to strerror_r() instead of errno. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
number argument but ignored it, calling strerror_r() with the
global errno instead. Any caller that saves an errno value (e.g.
after a failed syscall, once other code may have run and changed
the global errno) and then calls strError(saved_errno) would get
the message for whatever errno currently holds, not the one it
asked about. Fixed by passing errnum through to strerror_r()
instead of errno.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
This PR also adds a unit test (
StrErrorTest.cpp). It is auto-discovered and executed by the CTest suite proposed in #762 once that is merged; without that suite present the test file is inert and does not affect the build.