Fix out-of-bounds read parsing IPv4 SAN entries in TLS certs#812
Open
MarkRose wants to merge 1 commit into
Open
Fix out-of-bounds read parsing IPv4 SAN entries in TLS certs#812MarkRose wants to merge 1 commit into
MarkRose wants to merge 1 commit into
Conversation
- In SslX509ExtSubjectAltName's GEN_IPADD handling, an IPv4 iPAddress SAN is a 4-byte ASN.1 octet string, but the code dereferenced it as `*reinterpret_cast<const unsigned long*>(data)`, reading a full `unsigned long` (8 bytes on LP64/64-bit Linux) and thus 4 bytes past the end of the 4-byte buffer. Fixed by copying exactly 4 bytes into a uint32_t via memcpy before assigning to in_addr.s_addr. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAN is a 4-byte ASN.1 octet string, but the code dereferenced it as
*reinterpret_cast<const unsigned long*>(data), reading a fullunsigned long(8 bytes on LP64/64-bit Linux) and thus 4 bytes pastthe end of the 4-byte buffer. Fixed by copying exactly 4 bytes into
a uint32_t via memcpy before assigning to in_addr.s_addr.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com