Fix stale ssl_con_map entry after TcpConnection move-assignment#813
Open
MarkRose wants to merge 1 commit into
Open
Fix stale ssl_con_map entry after TcpConnection move-assignment#813MarkRose wants to merge 1 commit into
MarkRose wants to merge 1 commit into
Conversation
TcpConnection::operator=(TcpConnection&&) transferred m_ssl from the source object and nulled it out, but never updated the static ssl_con_map lookup table used by the OpenSSL verify callback to map an SSL* back to its owning TcpConnection. The map still pointed the SSL* key at the moved-from object. Since that object's m_ssl was now null, its destructor's cleanup path skipped erasing the stale entry, leaving ssl_con_map[ssl] referencing freed memory. A later TLS handshake invoking the verify callback would resolve the SSL* through this stale entry, causing a use-after-free. - In operator=(TcpConnection&&), after taking ownership of other.m_ssl, re-point ssl_con_map[m_ssl] at `this` so the map always reflects the live owner of the SSL* key. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TcpConnection::operator=(TcpConnection&&) transferred m_ssl from the
source object and nulled it out, but never updated the static
ssl_con_map lookup table used by the OpenSSL verify callback to map an
SSL* back to its owning TcpConnection. The map still pointed the SSL*
key at the moved-from object. Since that object's m_ssl was now null,
its destructor's cleanup path skipped erasing the stale entry, leaving
ssl_con_map[ssl] referencing freed memory. A later TLS handshake
invoking the verify callback would resolve the SSL* through this stale
entry, causing a use-after-free.
re-point ssl_con_map[m_ssl] at
thisso the map always reflects thelive owner of the SSL* key.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com