Added additional parameter TELEMETRY_SERVICE_AVAILABLE to support disabling Telemetry - #2034
semyonmelman wants to merge 30 commits into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 16606334 | Triggered | Generic High Entropy Secret | c58cd22 | src/test/resources/wiremock/mappings/wif/azure/invalid_issuer_flow.json | View secret |
| 16606335 | Triggered | Generic High Entropy Secret | c58cd22 | src/test/resources/wiremock/mappings/wif/azure/successful_flow_azure_functions.json | View secret |
| 16606336 | Triggered | Generic High Entropy Secret | c58cd22 | src/test/resources/wiremock/mappings/wif/azure/missing_sub_claim.json | View secret |
| 16606337 | Triggered | Generic High Entropy Secret | c58cd22 | src/test/resources/wiremock/mappings/wif/azure/missing_issuer_claim.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
The above secret(s) have been detected in your PR. Please take an appropriate action for each secret:
- If it’s a true positive, remove the secret from source code, revoke it and migrate to a secure way of storing and accessing secrets (see http://go/secrets-and-code). Once that’s done, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and resolve the incident.
- If it’s a false positive, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and ignore the incident.
- If you didn't add this secret - and only then - you may ignore this check as it's non-blocking. If you did add the secret and you ignore this check, you'll be assigned a "Security Finding" ticket in Jira in a few days.
Note:
- A secret is considered leaked from the moment it touches GitHub. Rewriting git history by force pushing or other means is not necessary and doesn’t change the fact that the secret has to be revoked.
- This check has a “Skip: false positive” button. Don’t use it. It will mark all detected secrets as false positives but only in the context of this specific run - it won’t remember this action in subsequent check runs.
If you encounter any problems you can reach out to us on Slack: #gitguardian-secret-scanning-help
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Added additional parameter TELEMETRY_SERVICE_AVAILABLE to support disabling Telemetry
Overview
SNOW-1881874
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: SNOW-1881874: CLIENT_TELEMETRY_ENABLED is always true and there is no possibility to override it #2029
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
So basically additional variable TELEMETRY_SERVICE_AVAILABLE was added to have control over isTelemetryServiceAvailable variable in TelemetryClient that was hardcoded.