Conversation
Contributor
|
Hi @jaroban ! |
This reverts commit 6819787.
Author
|
Done... there's a new PR + reverted this commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new constant for transport_key2 was added, but no corresponding 2nd transport key exists...
Also, the change was made only in the crypto_sha256_hmac_final function and not in crypto_sha256_hmac_init... this means that in one of the functions, (uint8_t*)1 or (uint8_t*)2 will be dereferenced and the memory there will be used as a key (!)
Either a 2nd key should be added or key 1 should be used.
This pull request removes the constant and uses key1.