Skip to content

Steam Beta Library - #120

Merged
Black4Blade merged 49 commits into
somini:masterfrom
julliansl:steam-library-beta
Sep 25, 2019
Merged

Steam Beta Library#120
Black4Blade merged 49 commits into
somini:masterfrom
julliansl:steam-library-beta

Conversation

@julliansl

@julliansl julliansl commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

Implemented a working solution for the new Steam Beta Library. not sure if there's anything else missing needed to be added, just worked towards having the new library get displayed.

Here are screenshots of what's in this PR: https://imgur.com/a/3xUcbTp

Also I believe I pulled some of @Black4Blade 's work since I forked from his repo, not sure what was included

This PR also takes into giving a solution for issue #119.

Black4Blade and others added 30 commits June 20, 2018 01:21
BPM button moved up top
Messed up add a game button to try to make an add a key button
Beta latest added missing colors
Added icons
Set Announcment to become brighter on hover in place of changing background color
Fixed the blue color on account button to only show when hovering over it
*Fixed thanks to RTDKillogy added invisible, busy, loooking to trade, looking to play into the friends menu from the bar

*Changed from Windows or linux to not OSX

*Changed from command SteamVR to run SteamVR app
Possible fix for issue 3 and 4
3 by updating a message (bar on top) that has not been handled in the root dialog file
4 by adding the upload screenshot file (maybe unhelpful)
This file may not be needed deleting to cut down on chance of having issues later on
Removed something that seem to have been commented for unknown reason
Fixed an XP unhandled message of End of life
*Testing for linux fix for libary issue:
*Huge font option
added the file gamespage_details_compat_subheader.layout
*added placement and layout for:
      *Controller Config
      *Fource Shutdown
Rename +8 tweak to beyondlargest
Fixed issue of unhandeled Button in Substreaming menu in settings
Placed under Secuirty code button
*Added placement for the unpair button in subsetting settings
*Added the second option of style for fixing sub streaming settings
Adding missing commits from master to beta fix
*Fixed order of buttons and handling in sub streaming in settings
Not sure what is this about
Maybe fixs for my git issues ignore this area
@Bluscream

Copy link
Copy Markdown
Contributor

Thanks

I noticed I overextended the margin to the left making Steam unabel to be resized horizontall on the left side.
@halbrd

halbrd commented Sep 21, 2019

Copy link
Copy Markdown
Collaborator

I've tested it on Windows 10 and it looks great, but I'm getting a horizontal line near the top of the library interface on Linux (Manjaro 18.1.0, KDE Plasma 5.16.4, using this commit https://github.com/JSyLucero/Pixelvision2/tree/05712d8168216b9b78a1edd85e065d4946e028fc)
image

Thanks for the PR!

@julliansl

julliansl commented Sep 21, 2019

Copy link
Copy Markdown
Collaborator Author

I've tested it on Windows 10 and it looks great, but I'm getting a horizontal line near the top of the library interface on Linux (Manjaro 18.1.0, KDE Plasma 5.16.4, using this commit https://github.com/JSyLucero/Pixelvision2/tree/05712d8168216b9b78a1edd85e065d4946e028fc)
image

Thanks for the PR!

@halbrd I'll try to see what I can do about that, although anyone else can attempt to pitch in a fix for it too

@julliansl

julliansl commented Sep 21, 2019

Copy link
Copy Markdown
Collaborator Author

I've put in a fix for the overlapped border issue @halbrd, it should be gone now.

@halbrd

halbrd commented Sep 22, 2019

Copy link
Copy Markdown
Collaborator

It looks great! And you fixed the icon alignment! 😍
image

Thanks for your work! I'm happy for this to be merged when you're done working on it.

@julliansl

julliansl commented Sep 22, 2019

Copy link
Copy Markdown
Collaborator Author

It looks great! And you fixed the icon alignment! 😍
image

Thanks for your work! I'm happy for this to be merged when you're done working on it.

Glad to hear that! I felt quite in the mood to test the waters with updating a Steam skin for once and PixelVision is a skin I don't want to part with so I decided to use this as a chance xD. I'm glad its turned out pretty well so far, I haven't any ideas of what else I would need to do though, I'll let you know whenever I'm finished @halbrd.

@halbrd

halbrd commented Sep 22, 2019

Copy link
Copy Markdown
Collaborator

@JSyLucero where did you learn to edit Steam skins? I'm a programmer but I have no knowledge of how Steam skins work and there doesn't seem to be much clear documentation.

@julliansl

julliansl commented Sep 22, 2019

Copy link
Copy Markdown
Collaborator Author

@halbrd tbh, I dabble quite often in CSS on front-end Web Dev, so the logic behind skins and the values in them remind me of it. A lot of my learning comes from inspection with trial and error. Because of how I'm kind of blindly learning by doing constant change and tests, I'm trying my best to change things slowly to find out how it exchanges visually, and honestly.... having to restart Steam every time makes this a time consuming experience xD...

Also, documentation really is scarce and it kind of hurts to be honest, especially since I only just started trying this out.

Edit: I just found out the page to really learning how to get control names, etc and what each attribute/property does in Steam skins, here's the page, apparently its called VGUI Editing

… Music Player Icon

I honestly almost forgot that the repositioning of the Big Picture Menu button would've change the placement of these...
… username on the left when Window is sized rather small in width

Here's an example screenshot of the issue: https://imgur.com/HCABxFp

I preferred what it was before, but... this is the compromise I guess.
@Black4Blade
Black4Blade merged commit 23a1670 into somini:master Sep 25, 2019
@julliansl
julliansl deleted the steam-library-beta branch November 13, 2019 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants