Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses an order-dependence that happens between
sig(:final)methods and mixins by making the final machinery skip cases where the "override" is actually an abstract method which would defer to the final method.Motivation
Previously, if we had a final method already defined (e.g. from a parent class) and we included a mixin which defines that method, we'd raise an error. However, sometimes that method isn't actually overriding the real method, particularly when including an abstract module where that method had been defined as abstract: in that case, we'd still be calling the final method. This meant that certain patterns would have had surprising runtime failures despite being accepted statically. For example, this would fail at runtime:
-> sorbet.run link
With this change, the above succeeds.
Test plan
See included automated tests. Added tests to exercise this case and show that it only happens when the "override" is happening from an abstract method.