Repository navigation
Fix termux - #2752
Fix termux#2752TzurSoffer wants to merge 11 commits into
Conversation
The TUR python3.13 package may not provide a pip3.13 executable on a clean install; bootstrapping pip via ensurepip makes the install step reliable.
With an unquoted delimiter, $1, $SONGS, and $SPOTDL were expanded (to empty strings) while generating the file, producing a script with a bash syntax error. Quoting EOL writes them literally so they expand when termux-url-opener actually runs.
rust and binutils were already installed before this change; the comment implied they were newly added for building spotdl deps.
Real Termux devices auto-detect the API level via getprop, but in the termux-docker image (used for testing under WSL) getprop is a broken stub and pydantic-core's maturin build aborts without this variable. Harmless on devices: it exports the same value getprop reports, with 24 (Termux's minimum supported API) as the fallback.
|
Thanks - committing a few changes, took me a while to set it up as a docker container on WSL/ubuntu for testing. |
There was a problem hiding this comment.
Pull request overview
Updates the Termux installation script to avoid Python 3.14 incompatibilities by explicitly installing and using Python 3.13, improving reliability of spotdl installs on Termux.
Changes:
- Adds
tur-repoand installspython3.13, then usespython3.13 -m pipfor installingspotdl. - Exports
ANDROID_API_LEVELto help native dependency builds in environments where auto-detection may not work. - Switches the
termux-url-openerheredoc to a quoted delimiter to prevent unintended variable expansion at generation time.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -18,7 +24,7 @@ if [ ! -f "$HOME/bin/termux-url-opener" ]; then | |||
| touch $HOME/bin/termux-url-opener | |||
| fi | |||
|
|
|||
| cat > $HOME/bin/termux-url-opener <<EOL | |||
| cat > $HOME/bin/termux-url-opener <<'EOL' | |||
Quote path variables, replace the mkdir guard with mkdir -p, and exit if cd fails so downloads can't silently land in $HOME. Also drop the redundant touch block: the cat redirection creates the file.
|
Awaiting user to test on an android device - I am android-less but have tested in WSL ubuntu termux docker environment. Ready to merge if user OK's/green lights |
|
pkg must be upgraded, or ffmpeg doesn't work (I'm pretty sure due to conflicts in tur-repo). Please check if this works for you @Silverarmor |
|
Note this doesn't have deno. |
|
I no longer have an android device to test 👀 |
|
Yes but I thought you had an emulator. I just made a small change and want to verify it. |
Fixes termux by using python 313 since 314 is not supported for curl cffi