Repository navigation
feat(i18n): 对齐 DBX 的 14 种语言并新增图标下拉选择 - #90
Open
Ezreal-byte wants to merge 2 commits into
Open
Ezreal-byte wants to merge 2 commits into
Ezreal-byte wants to merge 2 commits into
Conversation
Bundle all 14 languages with complete catalogs, persistent locale choices, and a keyboard-accessible select using the DBX flag assets and text marker. Refs: t8y2#89 Framework companion: vivaui/viva#49
This was referenced Oct 28, 2026
Record catalog maintenance, complete SVG asset generation, and the shared select API dependency for reproducible builds and review. Refs: t8y2#89 Framework companion: vivaui/viva#50 Framework commit: vivaui/viva@0c7d762
Owner
|
感谢这份投入,先把决定写在这里:这个 PR 保持 open,暂不合并,也请你先不要关闭。 不合并的原因不是实现质量,而是现阶段的产品取舍。14 种语言的完整目录意味着以后每加一条界面文案都要同步 14 份,同时默认产物会增加约 1.34 MiB,首次切换语言多约 5 ms 解码、每种用过的语言常驻约 66–141 KiB。目前多语言用户量还撑不起这份长期维护和体积成本,先把复杂度挡在门外更划算。 所以这份 PR 先当作后续按需增量的参考保留:等某几种语言的用户量起来,再按语言逐批引入(一次一到两种),复用这里的 catalog 结构、语言列表、系统语言匹配,以及 Select 的图片/文字前缀。Viva 侧能力已经随 vivaui/viva#50 合入,不需要再等框架。 现在不用继续在这上面投入,也不用关 PR。等我们准备启动时会在这里回复,先 rebase 到当时的 main、让 CI 跑绿再继续;期间如果你有新进展,也欢迎直接推到当前分支。 Thanks for the contribution — keeping this open as the reference for adding languages incrementally. |
Ezreal-byte
marked this pull request as draft
October 28, 2026 07:09
Ezreal-byte
marked this pull request as ready for review
October 28, 2026 07:10
|
其实用不着这么多语言,中英其实已经覆盖90%场景了 |
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89
语言设置从两个分段选项改为带图标的下拉框,支持与 DBX 一致的 14 种语言。简体中文、繁体中文、English 位于前三项,其余按 DBX 原顺序排列。
改动
Viva 配套
图片与文字前缀、滚动列表跨可视区域的焦点修复属于通用组件和输入能力,实现在 Viva;Motty 使用其公共 Select API。
配套 PR:vivaui/viva#50(验证提交:
0c7d7622b82f88049465f10b9091edb7c62c8ce3)。框架 issue:vivaui/viva#49。Motty CI 当前会检出 Viva main,需要配套修改合入后才能通过新 API 的编译。
验证
go vet ./...、go vet -tags dev ./internal/workbench通过。go test ./... -count=1在本机仍有两项既有 Windows 基线失败:TestOnlyAStandardUserInstallationReplacesItself、TestSSHSyncOffersTheIdentityFileOnce;另有internal/ai/cli的测试可执行文件被 Windows 以Access is denied拒绝启动。未将这些结果记为通过。截图
语言下拉框
切换语言后的界面