Repository navigation
Fix image.h guard - #113
Merged
Merged
Conversation
Owner
|
Good catch. Thanks!
With ESP32? |
Contributor
Author
Yes, with ESP32 and ESP/IDF version 4.4.5. I just tried in the |
Contributor
Author
|
The |
Contributor
Author
|
I guess that the code is anyhow not thread safe, so you could solve this issue by defining the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
image.hfile has the same guard aspixel.h, soimage.hdoes not get included.Note : I also had to increase the stack size to use the function
hagl_load_image. Perhaps a note in the documentation could be useful.