Skip to content

Docs: remove v4 reference on homepage - #38946

Merged
mdo merged 1 commit into
mainfrom
main-jd-docs-drop-v4-reference-in-homepage
Jul 24, 2023
Merged

Docs: remove v4 reference on homepage#38946
mdo merged 1 commit into
mainfrom
main-jd-docs-drop-v4-reference-in-homepage

Conversation

@julien-deramond

@julien-deramond julien-deramond commented Jul 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR removes the v4 reference on the homepage.

Before:
Screenshot 2023-07-21 at 08 49 54

In this PR:
Screenshot 2023-07-21 at 08 49 45

Motivation & Context

v4 is now deprecated/not supported so having it on the homepage IMO is a bit weird since it's not to be used anymore.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond added docs Documentation site and its content v5 v5, the v5-dev branch enhancement Legacy: use feature labels Jul 21, 2023
@julien-deramond
julien-deramond marked this pull request as ready for review July 21, 2023 06:50
@XhmikosR
XhmikosR requested a review from mdo July 23, 2023 19:15
mdo
mdo approved these changes Jul 24, 2023
View reviewed changes

@mdo mdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@mdo
mdo merged commit 4271d22 into main Jul 24, 2023
@mdo
mdo deleted the main-jd-docs-drop-v4-reference-in-homepage branch July 24, 2023 04:27
@XhmikosR XhmikosR removed the enhancement Legacy: use feature label Jul 26, 2023
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
This was referenced May 19, 2024
Open
Open
@Hamberfim Hamberfim mentioned this pull request May 21, 2024
Merged
@V1CTORY360 V1CTORY360 mentioned this pull request May 22, 2024
Open
This was referenced May 24, 2024
Open
Open
@devcurt696 devcurt696 mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Guiguiiz92 Guiguiiz92 mentioned this pull request May 24, 2024
Open
@Cpano Cpano mentioned this pull request May 24, 2024
Open
@zxcv32 zxcv32 mentioned this pull request May 24, 2024
Open
@V1CTORY360 V1CTORY360 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@ngochoangg ngochoangg mentioned this pull request May 24, 2024
Open
@jadsongmatos jadsongmatos mentioned this pull request May 24, 2024
Open
@bich-samrouth bich-samrouth mentioned this pull request May 24, 2024
Open
@RodolfoBorbon RodolfoBorbon mentioned this pull request May 24, 2024
Open
@SherfeyInv SherfeyInv mentioned this pull request May 25, 2024
Merged
@GTVolk GTVolk mentioned this pull request Sep 13, 2024
Open
@martinez-ml martinez-ml mentioned this pull request Sep 14, 2024
Merged
@GTVolk GTVolk mentioned this pull request Sep 14, 2024
Open
@Cpano Cpano mentioned this pull request Sep 17, 2024
Open
@GTVolk GTVolk mentioned this pull request Sep 17, 2024
Open
@Cpano Cpano mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 18, 2024
Open
Open
Open
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
@pinco227 pinco227 mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 28, 2024
Open
Open
Open
Open
@Akhamesra Akhamesra mentioned this pull request Oct 2, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 3, 2024
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@Gutts-n Gutts-n mentioned this pull request Oct 5, 2024
Open
@Kimahari Kimahari mentioned this pull request Oct 5, 2024
Merged
This was referenced Oct 12, 2024
Open
Open
Open
Open
@Arrhenius09 Arrhenius09 mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdo mdo mdo approved these changes

Assignees

No one assigned

Labels

docs Documentation site and its content v5 v5, the v5-dev branch

Projects

No open projects
v5.3.1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@julien-deramond @mdo @XhmikosR