Repository navigation
Docs: add missing Accordion component in the list of JS components - #39980
Merged
Merged
Conversation
…nheriting of Collapse)
hannahiss
marked this pull request as ready for review
May 14, 2024 11:39
julien-deramond
self-requested a review
May 14, 2024 11:42
julien-deramond
approved these changes
May 14, 2024
julien-deramond
left a comment
Member
There was a problem hiding this comment.
Good catch @hannahiss! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add missing Accordion component in the list of JS components (inheriting of Collapse)
Motivation & Context
Accordion is inheriting from Collapse plugin, so collapse.js should be imported in order to make Accordions work correctly (in case of a js optimized import)
Type of changes
Checklist
npm run lint)Live previews
Related issues