Repository navigation
Docs: Update WCAG links and references - #40703
Merged
Merged
Conversation
julien-deramond
approved these changes
Aug 7, 2024
julien-deramond
left a comment
Member
There was a problem hiding this comment.
These modifications look good to me, the links go to the same corresponding content in WCAG 2.2, and using "/WCAG/" (without the version) is better IMO.
There's a change that could be done also in scss/mixins/_visually-hidden.scss:
diff --git a/scss/mixins/_visually-hidden.scss b/scss/mixins/_visually-hidden.scss
index 082aeec95..388916ccf 100644
--- a/scss/mixins/_visually-hidden.scss
+++ b/scss/mixins/_visually-hidden.scss
@@ -24,7 +24,7 @@
// Use to only display content when it's focused, or one of its child elements is focused
// (i.e. when focus is within the element/container that the class was applied to)
//
-// Useful for "Skip to main content" links; see https://www.w3.org/TR/2013/NOTE-WCAG20-TECHS-20130905/G1
+// Useful for "Skip to main content" links; see https://www.w3.org/WAI/WCAG22/Techniques/general/G1.html
@mixin visually-hidden-focusable() {
&:not(:focus):not(:focus-within) {
julien-deramond
self-requested a review
August 7, 2024 09:16
julien-deramond
approved these changes
Aug 7, 2024
Member
|
Handing it over to @patrickhlauke for final review |
patrickhlauke
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update all the WCAG links and references from 2.1 to 2.2.
Motivation & Context
Be up to date with the last version of the WCAG.
Type of changes
Checklist
npm run lint)Live previews
Related issues
NA