Fix wrong ibid position, test transparent locators - #399
Merged
Merged
Conversation
reknih
approved these changes
Sep 26, 2025
reknih
left a comment
Member
There was a problem hiding this comment.
First I thought it was wrong, but upon closer inspection, the second branch says "This is none, last is some" so it matches the spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the CSL spec1 (emphasis mine):
Prior logic only checked if the locators differed in any way, assigning "ibid with locator" if so. But that included differing by the previous citation having a locator and the current one not having one, whereas that case should be handled differently per the spec, and the position should be subsequent instead.
(Related: #301, though that fixed a different bug.)
Added tests for transparent locators, which not only verify this behavior has been fixed but also properly test the additions in #299.
Footnotes
https://docs.citationstyles.org/en/stable/specification.html#choose ↩