Fix error in math argument parsing when dots aren't followed by anything - #7105
Merged
Merged
Conversation
isuffix
force-pushed
the
push-ryykoputknyv
branch
from
October 10, 2025 23:58
f550f44 to
cdb5e8c
Compare
isuffix
force-pushed
the
push-ryykoputknyv
branch
from
October 10, 2025 23:58
cdb5e8c to
75e996c
Compare
Member
|
Does this solely change error cases into non-error cases or can it also affect behavior in cases that previously compiled? |
Collaborator
Author
|
This should only effect error cases. I can't think of any way this would impact already compiling code. |
Member
|
Thanks, seems sensible! |
laurmaedje
pushed a commit
that referenced
this pull request
Oct 16, 2025
Dikluwe
pushed a commit
to Dikluwe/typst-crystalline
that referenced
this pull request
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RE: #7036 (comment)
This is a bug fix for an error in the math parser when using two dots not followed by anything, e.g.
$func(..)$.I chose to avoid refactoring the entire
math_argfunction to make the change easier to review and hopefully get in for 0.14, but I left a TODO comment for myself for later.