feat: add option to use font-based icon sizing#3882
Open
natew wants to merge 1 commit into
Open
Conversation
|
🚅 Deployed to the tamagui-pr-3882 environment in tamagui
|
natew
commented
Feb 6, 2026
| const size = | ||
| typeof props.size === 'string' | ||
| ? getTokenValue(props.size as any, 'size') | ||
| : props.size || (styledContext.size === '$true' ? undefined : styledContext.size) |
Member
Author
There was a problem hiding this comment.
i think wrong actually - we'd expect <Icon size="$4" to actually be font-size body $4 so useIconSize shouldnt return contextSize but actual final size
natew
commented
Feb 6, 2026
| const iconSize = | ||
| (typeof size === 'number' ? size * 0.5 : getFontSize(size as FontSizeTokens)) * | ||
| scaleIcon | ||
| const iconSize = useIconSize({ |
Member
Author
There was a problem hiding this comment.
and then i guess here we'd basically want something better tbh - we have SizeContext already too, maybe we avoid passing any props or cloning at all? and just icons can read the SizeContext and decide themselves using their own themed wrapper.
For non-tamagui icons we do nothing, but we can document wrapping them easily with themed, we should really rename that helper, put it in a cleaner package name, etc, and document
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.