ci(detox): directUseCase launch pattern across all e2e tests (drops per-test navigation)#4019
Open
natew wants to merge 3 commits into
Open
ci(detox): directUseCase launch pattern across all e2e tests (drops per-test navigation)#4019natew wants to merge 3 commits into
natew wants to merge 3 commits into
Conversation
|
🚅 Deployed to the tamagui-pr-4019 environment in tamagui
|
…se launch (no per-test nav), revert shard rebalance
…se helper) — drops per-test home→quick-nav navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every kitchen-sink Detox e2e test now relaunches straight into its use case via
launchArgs: { directUseCase }(newreloadUseCasehelper ine2e/utils/detox.ts), instead ofsafeReloadApp()+navigateToTestCase()(relaunch → home → expand quick-nav grid → tap, ~60-90s/test).The app already supported this (
App.native.tsxrenders the use-case component at root inside all providers);SheetKeyboardFitContentwas the only file using it. This rolls it out everywhere.Why
The 71-min run that started this was a degraded-runner cold-bundle flake, not a regression. The steady cost is the per-test home→quick-nav navigation. A first attempt to fix it by rebalancing shards was a net regression (built on noisy single-run estimates; two high-variance files spiked together). Reverted. The real lever is removing the navigation itself.
Scope
noRnghkeepsdisableGestureHandler;CompilerExtractionkeeps its in-test build;check-rngh-status(home-screen test) andSheetKeyboardDrag(describe.skip) untouched.Validation
tsc -p e2e/tsconfig.json+oxfmt+oxlint+check-ios-detox-shards.mjsall green. Runtime = this Detox run.