fix(radio-group): remove stray v1 pressTheme prop that leaks to the DOM on web#4075
Open
sstur wants to merge 1 commit into
Open
fix(radio-group): remove stray v1 pressTheme prop that leaks to the DOM on web#4075sstur wants to merge 1 commit into
sstur wants to merge 1 commit into
Conversation
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4074
pressThemewas a v1 prop that the v2 style system no longer consumes, butRadioGroupIndicatorFramestill sets it in itsunstyled: falsevariant. Since nothing extracts it anymore, it passes through to the underlying element on web, putting apressthemeattribute on the DOM and logging a React unknown-prop console error the first time a radio option is selected (the Indicator only mounts once its item is checked).This removes the line — v2 already applies press feedback via the Item's
pressStyle, so there's no visual change. Verified withbun run buildincode/ui/radio-group, and confirmed in an Expo SDK 57 / react-native-web app (via a pnpm patch of the published package) that the console error is gone and radio behavior is unchanged.🤖 Generated with Claude Code