fix: negative bigint formatting and session remaining_secs clock - #144
Open
kutluhaneth46 wants to merge 5 commits into
Open
kutluhaneth46 wants to merge 5 commits into
kutluhaneth46 wants to merge 5 commits into
Conversation
Pad absolute fractional digits first, then apply the sign, so values like -5n with 6 decimals become -0.000005 instead of 0.0000-5. Part of tempoxyz#88.
Lock the sign-outside-fractional-digits behavior for zero, fractional, and whole negative bigint inputs. Closes tempoxyz#88.
Avoid a clock tick between the grace comparison and subtraction that could yield a negative remaining_secs. Fixes tempoxyz#87.
Record patch entries for tempoxyz#87 and tempoxyz#88.
Document the race the previous fix removes so it is not reintroduced.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small correctness fixes in wallet-cli shared utilities and session listing.
Changes
biginttoken/credit balances without embedding the minus sign inside padded fractional digits (#88)nowSeconds()when computing sessionremaining_secsso a clock tick cannot produce a negative countdown (#87)Closes #88
Closes #87