Prepare for 20% of the production traffic #30
Conversation
- Use cdn.changelog.com for the assets host - Bump a few dependency versions Just a tiny step towards rc.2... Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
WalkthroughThis update revises configuration and documentation across several files. It upgrades tool and image versions, updates host URLs from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/_namespace.yml(1 hunks)README.md(2 hunks)container/justfile(1 hunks)dagger/main.go(3 hunks)justfile(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
.github/workflows/_namespace.yml (1)
Learnt from: gerhard
PR: #23
File: just/op.just:14-22
Timestamp: 2025-07-05T06:17:05.678Z
Learning: In justfile/just targets, the user prefers using && operators for error handling rather than set -e, as the && chain already provides fail-fast behavior without additional shell options.
dagger/main.go (1)
Learnt from: gerhard
PR: #18
File: dagger/main.go:292-304
Timestamp: 2025-07-03T08:51:11.320Z
Learning: When Go tools in dagger/main.go are pinned to specific commit hashes rather than release tags, this is intentional to access newer changes not yet included in releases. Avoid suggesting updates to release tags when commits are used, as the commits likely contain important unreleased features or fixes.
🔇 Additional comments (6)
container/justfile (1)
47-48: Consistent asset-host update looks correct
The swap tocdn.changelog.comaligns with the rest of the repository and keeps acceptance tests in sync with production..github/workflows/_namespace.yml (1)
24-24: Confirmextractions/setup-just@v2Installs just v1.42.3
The workflow relies on theextractions/setup-just@v2step to installjustat version 1.42.3. Please verify that:
- The action’s v2 release supports
just1.42.3- Hosted or self-hosted runners actually receive the 1.42.3 binary (and not an older cached version)
Locations to check:
- File: .github/workflows/_namespace.yml
- Step:
- uses: extractions/setup-just@v2 with: just-version: "1.42.3"README.md (2)
1-1: Trademark symbol still present – summary claims it was removed
The AI summary says the “™” was dropped, but line 1 still showsPipely™.Likely an incorrect or invalid review comment.
40-46: Road-map numbers only touch docs – no action required
The updated percentages are documentation-only; no code impact detected.justfile (1)
54-55: Asset host switch is fine
Change mirrors the container recipe; 👍 for keeping a single canonical host.dagger/main.go (1)
14-15: Verified SHA256 Digests for Go and Varnish
The SHA256 digests in dagger/main.go now exactly match the values returned by Docker Hub for:
- golang:1.24.5@sha256:ef5b4be1f94b36c90385abd9b6b4f201723ae28e71acacb76d00687333c17282 (lines 14–15)
- varnish:7.7.1@sha256:1a684d37ec7a4f441a36c84945ee7713d1ddd59e8204d4040aeecb529ed4f68e (lines 71–72, 92–93)
No further changes needed.
| PURGE_TOKEN="op://pipely/purge/credential" \ | ||
| HONEYCOMB_DATASET="pipedream" | ||
| HONEYCOMB_API_KEY="op://pipely/honeycomb/credential" \ | ||
| AWS_ACCESS_KEY_ID="op://pipely/aws-s3-logs/access-key-id" \ | ||
| AWS_SECRET_ACCESS_KEY="op://pipely/aws-s3-logs/secret-access-key" \ | ||
| just op run -- bash -c 'flyctl secrets set --stage HONEYCOMB_DATASET="$HONEYCOMB_DATASET" HONEYCOMB_API_KEY="$HONEYCOMB_API_KEY" PURGE_TOKEN="$PURGE_TOKEN" AWS_ACCESS_KEY_ID="$AWS_ACCESS_KEY_ID" AWS_SECRET_ACCESS_KEY="$AWS_SECRET_ACCESS_KEY"' | ||
| just op run -- bash -c 'flyctl secrets set --stage HONEYCOMB_DATASET="pipedream" HONEYCOMB_API_KEY="$HONEYCOMB_API_KEY" PURGE_TOKEN="$PURGE_TOKEN" AWS_ACCESS_KEY_ID="$AWS_ACCESS_KEY_ID" AWS_SECRET_ACCESS_KEY="$AWS_SECRET_ACCESS_KEY"' | ||
| flyctl secrets list |
There was a problem hiding this comment.
Secrets recipe will NOT expand variables – breaking deployment
Single-quoting the entire flyctl secrets set … string prevents $HONEYCOMB_API_KEY, $PURGE_TOKEN, etc. from expanding.
- just op run -- bash -c 'flyctl secrets set --stage HONEYCOMB_DATASET="pipedream" HONEYCOMB_API_KEY="$HONEYCOMB_API_KEY" PURGE_TOKEN="$PURGE_TOKEN" AWS_ACCESS_KEY_ID="$AWS_ACCESS_KEY_ID" AWS_SECRET_ACCESS_KEY="$AWS_SECRET_ACCESS_KEY"'
+ just op run -- bash -c \
+ "flyctl secrets set --stage \
+ HONEYCOMB_DATASET=\"pipedream\" \
+ HONEYCOMB_API_KEY=\"$HONEYCOMB_API_KEY\" \
+ PURGE_TOKEN=\"$PURGE_TOKEN\" \
+ AWS_ACCESS_KEY_ID=\"$AWS_ACCESS_KEY_ID\" \
+ AWS_SECRET_ACCESS_KEY=\"$AWS_SECRET_ACCESS_KEY\""Without this, literal strings reach Fly.io and credentials never update.
🤖 Prompt for AI Agents
In justfile around lines 145 to 150, the flyctl secrets set command is enclosed
in single quotes, which prevents environment variables like $HONEYCOMB_API_KEY
and $PURGE_TOKEN from expanding. To fix this, replace the single quotes around
the bash command with double quotes or remove the quotes so that the shell
expands these variables before passing them to flyctl. This ensures the actual
secret values are sent to Fly.io instead of literal variable names.
Just a tiny step towards
rc.2🚶Summary by CodeRabbit
Documentation
Chores
justtool used in workflow configuration.cdn2.changelog.comtocdn.changelog.comin configuration and scripts.