Skip to content

Conversation

@gerhard
Copy link
Member

@gerhard gerhard commented Oct 5, 2025

Also update a bunch of other dependencies so that everything is running on latest.

Summary by CodeRabbit

  • Documentation

    • Updated roadmap with v1.0-rc.7 (includes Varnish 7.7.3, Vector 0.49.0, MP3 uploads support) and v1.0-rc.8 (process supervisor change), each with checklists.
  • Chores

    • Upgraded tooling and platform versions for stability: Go 1.24.7, Varnish 7.7.3, Vector 0.49.0, Hurl 7.0.0, Oha 1.10.0, Dagger 0.19.0, OP CLI 2.32.0.
  • Tests

    • Relaxed initial page-load timing threshold in an acceptance test to reduce flakiness.

@coderabbitai
Copy link

coderabbitai bot commented Oct 5, 2025

Walkthrough

Updates pinned tool and image versions across build scripts, bumps Dagger/Hurl/1Password CLI versions, adjusts Varnish default tag, adds two roadmap release entries to README, and relaxes a cold-load test latency assertion. No control-flow or public API changes.

Changes

Cohort / File(s) Summary of changes
Documentation updates
README.md
Added roadmap entries: v1.0-rc.7 (update to Varnish v7.7.3, Vector v0.49.0, add mp3 uploads) and v1.0-rc.8 (replace overmind with runit); checklist items added.
Dagger build versions
dagger/main.go
Bumped static image/version constants: Go 1.24.5→1.24.7, tls-exterminator commit, Vector 0.47.0→0.49.0 (new digest), Hurl 6.1.1→7.0.0, oha 1.9.0→1.10.0; Varnish default tag updated to 7.7.3 (new digest).
Justfile: Dagger CLI
just/dagger.just
Updated DAGGER_VERSION 0.18.14 → 0.19.0; derived variables updated accordingly.
Justfile: Hurl
just/hurl.just
Updated HURL_VERSION 6.1.1 → 7.0.0; affects name and download URL.
Justfile: 1Password CLI
just/op.just
Updated OP_VERSION 2.31.1 → 2.32.0; adjusts artifact name and download URL.
Acceptance test threshold
test/acceptance/pipedream/homepage.hurl
Increased cold-load allowed duration from 500ms → 1000ms; other assertions unchanged.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • mttjohnson
  • nabsul

Poem

A rabbit tweaks the version vines,
nudges tags and reads the lines.
Vector hums and Hurl hops through,
varnish shines a fresher hue.
Tests relax — one gentle beat; release carrots smell sweet. 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly highlights the principal updates to Varnish and Vector, which are the main focus of the pull request, without unnecessary detail or ambiguity, making it immediately clear to reviewers what the change entails.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-varnish-and-vector

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5b96f47 and d0dd50d.

📒 Files selected for processing (6)
  • README.md (1 hunks)
  • dagger/main.go (2 hunks)
  • just/dagger.just (1 hunks)
  • just/hurl.just (1 hunks)
  • just/op.just (1 hunks)
  • test/acceptance/pipedream/homepage.hurl (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • just/op.just
  • README.md
  • test/acceptance/pipedream/homepage.hurl
  • just/hurl.just
  • just/dagger.just
🔇 Additional comments (3)
dagger/main.go (3)

26-26: Adjust for Hurl 7.0.0’s replace filter change.

Hurl 7.0.0’s only breaking change is that the replace filter no longer accepts regex—use replaceRegex for regex replacements. Scan your .hurl tests for any regex‐based replace calls and update them accordingly.


14-14: LGTM — approve Go and Varnish patch updates
Golang 1.24.7 and Varnish 7.7.3 include upstream fixes with no known critical advisories; SHA256 hashes ensure reproducibility. Continue standard OS/base-image CVE scans.


17-17: Verify Vector 0.49.0 upgrade and tls-exterminator pin

  • Vector: 0.49.0 includes VRL function-breaking changes, protobuf codec limitations, aws_s3 retry_strategy default change, plus new websocket source, HTTP templating, enrichment watch, and Prometheus TTL. Review the 0.49 upgrade guide and adjust configs accordingly.
  • tls-exterminator: currently pinned to a commit hash; consider switching to a semver tag or documenting changelog for traceability.
  • oha bump to 1.10.0 is routine.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78a4a4c and 5b96f47.

📒 Files selected for processing (6)
  • README.md (1 hunks)
  • dagger/main.go (2 hunks)
  • just/dagger.just (1 hunks)
  • just/hurl.just (1 hunks)
  • just/op.just (1 hunks)
  • test/acceptance/pipedream/homepage.hurl (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: on-namespace / run
🔇 Additional comments (8)
test/acceptance/pipedream/homepage.hurl (1)

5-5: Verify the justification for doubling the cold cache load threshold.

The duration threshold has been relaxed from 500ms to 1000ms for cold cache loads. This change could mask performance regressions.

Please confirm this change is intentional and whether it's related to performance characteristics of the updated Varnish v7.7.3 or Vector v0.49.0. Consider documenting the reason in a comment or commit message.

dagger/main.go (6)

14-14: LGTM: Golang patch version update.

The Golang version update from 1.24.5 to 1.24.7 is a patch release that should contain bug fixes without breaking changes.


23-23: LGTM: Vector updated to v0.49.0 as per PR objectives.

The Vector version update from 0.47.0-debian to 0.49.0-debian aligns with the PR title and objectives.


26-26: LGTM: Hurl version consistent with just/hurl.just.

The Hurl version update from 6.1.1 to 7.0.0 is consistent with the version in just/hurl.just. Ensure breaking changes are reviewed as noted in the hurl.just file review.


69-69: LGTM: Varnish updated to v7.7.3 as per PR objectives.

The Varnish default version update from 7.7.1 to 7.7.3 aligns with the PR title. The SHA256 hash ensures image integrity.


17-17: Commit hash 93583389e8bab9b519466d95e69e594682d8de5b verified. Ensure the changes in this commit introduce no breaking changes to tls-exterminator.


29-29: Confirmed oha v1.10.0 availability. The GitHub release exists and the download URL returns a 302 redirect to the asset.

just/op.just (1)

4-4: 1Password CLI v2.32.0 availability verified. Download URL returns HTTP 200.

Also update a bunch of other dependencies so that everything is running
on latest.

Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
@gerhard gerhard force-pushed the update-varnish-and-vector branch from 5b96f47 to d0dd50d Compare October 5, 2025 15:14
@gerhard gerhard merged commit 6ce9f24 into main Oct 5, 2025
4 checks passed
@gerhard gerhard deleted the update-varnish-and-vector branch October 5, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants