-
Notifications
You must be signed in to change notification settings - Fork 2
Update to Varnish v7.7.3 & Vector v0.49.0 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates pinned tool and image versions across build scripts, bumps Dagger/Hurl/1Password CLI versions, adjusts Varnish default tag, adds two roadmap release entries to README, and relaxes a cold-load test latency assertion. No control-flow or public API changes. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
README.md(1 hunks)dagger/main.go(2 hunks)just/dagger.just(1 hunks)just/hurl.just(1 hunks)just/op.just(1 hunks)test/acceptance/pipedream/homepage.hurl(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: on-namespace / run
🔇 Additional comments (8)
test/acceptance/pipedream/homepage.hurl (1)
5-5: Verify the justification for doubling the cold cache load threshold.The duration threshold has been relaxed from 500ms to 1000ms for cold cache loads. This change could mask performance regressions.
Please confirm this change is intentional and whether it's related to performance characteristics of the updated Varnish v7.7.3 or Vector v0.49.0. Consider documenting the reason in a comment or commit message.
dagger/main.go (6)
14-14: LGTM: Golang patch version update.The Golang version update from 1.24.5 to 1.24.7 is a patch release that should contain bug fixes without breaking changes.
23-23: LGTM: Vector updated to v0.49.0 as per PR objectives.The Vector version update from 0.47.0-debian to 0.49.0-debian aligns with the PR title and objectives.
26-26: LGTM: Hurl version consistent with just/hurl.just.The Hurl version update from 6.1.1 to 7.0.0 is consistent with the version in
just/hurl.just. Ensure breaking changes are reviewed as noted in the hurl.just file review.
69-69: LGTM: Varnish updated to v7.7.3 as per PR objectives.The Varnish default version update from 7.7.1 to 7.7.3 aligns with the PR title. The SHA256 hash ensures image integrity.
17-17: Commit hash 93583389e8bab9b519466d95e69e594682d8de5b verified. Ensure the changes in this commit introduce no breaking changes to tls-exterminator.
29-29: Confirmed oha v1.10.0 availability. The GitHub release exists and the download URL returns a 302 redirect to the asset.just/op.just (1)
4-4: 1Password CLI v2.32.0 availability verified. Download URL returns HTTP 200.
Also update a bunch of other dependencies so that everything is running on latest. Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
5b96f47 to
d0dd50d
Compare
Also update a bunch of other dependencies so that everything is running on latest.
Summary by CodeRabbit
Documentation
Chores
Tests