Repository navigation
Conversation
…r reverse proxy trust
Author
|
Checking in after about two months: this closes a rate-limit bypass we confirmed exploitable live, so a look would help a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Telegram Chat and following thiese docs:
https://github.com/express-rate-limit/express-rate-limit/wiki/Troubleshooting-Proxy-Issues
and
https://expressjs.com/en/guide/behind-proxies/
i propose a modification to avoid the IP overriding in case of TRUST_PROXY configuration