Skip to content

close S3 response input stream#1166

Merged
bennetelli merged 1 commit into
togglz:masterfrom
sullis:sean/s3-close-response-input-stream
Mar 21, 2024
Merged

close S3 response input stream#1166
bennetelli merged 1 commit into
togglz:masterfrom
sullis:sean/s3-close-response-input-stream

Conversation

@sullis

@sullis sullis commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@sullis

sullis commented Mar 4, 2024

Copy link
Copy Markdown
Contributor Author

WDYT? @bennetelli

@sullis

sullis commented Mar 20, 2024

Copy link
Copy Markdown
Contributor Author

cc: @bennetelli

@bennetelli bennetelli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for your PR @sullis :)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.31%. Comparing base (fda0e51) to head (efe1e66).
Report is 12 commits behind head on master.

Files Patch % Lines
...src/main/java/org/togglz/s3/S3StateRepository.java 83.33% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1166      +/-   ##
============================================
- Coverage     55.40%   55.31%   -0.09%     
  Complexity      930      930              
============================================
  Files           180      180              
  Lines          4606     4597       -9     
  Branches        603      604       +1     
============================================
- Hits           2552     2543       -9     
+ Misses         1896     1895       -1     
- Partials        158      159       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bennetelli
bennetelli merged commit 4538a0c into togglz:master Mar 21, 2024
@sullis
sullis deleted the sean/s3-close-response-input-stream branch March 21, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants