Conversation
spl_perform_arch_fixups() looks up the "socfpga-smmu-secure-config" node by name and calls hang() on any error, so every SoC64 platform is forced to carry the node even when it has nothing to program. Treat a missing node (-ENODEV) as "nothing to do" and skip it, while still calling hang() on a genuine probe/dtreg failure when the node is present. This lets parts where the System-Manager TBU stream-ID / secure-SID setup is owned elsewhere (e.g. by ATF/BL31), or where the reset default already suffices, omit the node without hanging. Legacy SoC64 parts that still program it from U-Boot keep the existing error detection. Signed-off-by: Chen Huei Lok <chen.huei.lok@altera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Pipeline Test
spl_perform_arch_fixups() looks up the "socfpga-smmu-secure-config" node by name and calls hang() on any error, so every SoC64 platform is forced to carry the node even when it has nothing to program.
Treat a missing node (-ENODEV) as "nothing to do" and skip it, while still calling hang() on a genuine probe/dtreg failure when the node is present. This lets parts where the System-Manager TBU stream-ID / secure-SID setup is owned elsewhere (e.g. by ATF/BL31), or where the reset default already suffices, omit the node without hanging. Legacy SoC64 parts that still program it from U-Boot keep the existing error detection.
Please do not submit a Pull Request via github. Our project makes use of
mailing lists for patch submission and review. For more details please
see https://u-boot.readthedocs.io/en/latest/develop/sending_patches.html
The only exception to this is in order to trigger a CI loop on Azure prior
to posting of patches.