Skip to content

rm: report traversal failed on getdents EIO - #15209

Open
Franklin-Qi wants to merge 1 commit into
uutils:mainfrom
Franklin-Qi:feature-issue#15206-rm-traversal-failed
Open

Franklin-Qi wants to merge 1 commit into
uutils:mainfrom
Franklin-Qi:feature-issue#15206-rm-traversal-failed

Conversation

@Franklin-Qi

Copy link
Copy Markdown
Contributor

When directory listing fails mid-walk (e.g. injected getdents EIO), emit GNU's "traversal failed" even under -f instead of later "Directory not empty".

Closes: #15206

Comment thread tests/by-util/test_rm.rs Outdated
Comment thread src/uu/rm/src/platform/unix.rs Outdated
When directory listing fails mid-walk (e.g. injected getdents EIO),
emit GNU's "traversal failed" even under -f instead of later
"Directory not empty".

Closes: uutils#15206
@Franklin-Qi
Franklin-Qi force-pushed the feature-issue#15206-rm-traversal-failed branch from d0e68dc to 63bd6f2 Compare October 10, 2026 10:44
@codspeed

codspeed Bot commented Oct 10, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 4.46%

⚠️ 4 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 7 untouched benchmarks
⏩ 448 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ ⚠️ Simulation rm_recursive_tree 14.4 ms 13.8 ms +4.46%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Franklin-Qi:feature-issue#15206-rm-traversal-failed (63bd6f2) with main (38336e9)

Open in CodSpeed

Footnotes

  1. 448 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rm: "traversal failed" is not shown when 2nd getdents64 failed on broken device

3 participants