Reject buffered writes after BufferedWriteSyncer.Stop - #1594
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BufferedWriteSyncer.Write currently returns success after Stop, buffering data after the periodic flush loop has exited. Calling Stop again does not flush that data. Stop before the first Write also permits the writer to start later.
Record the stopped state even before initialization and return io.ErrClosedPipe with zero bytes for subsequent writes. Document the behavior and test both initialized and unused writers, including repeated Stop calls.
Validation: both new regression cases fail before the fix. Full make test passed with the race detector across all four modules. make lint reports two existing gofumpt findings; both were reproduced with unchanged upstream implementation. No new lint finding was introduced.
Prepared with Codex assistance.