Skip to content

Exposing Experimental PolygonToCells and Updating to Master#68

Merged
zachcoleman merged 2 commits into
uber:masterfrom
zachcoleman:zcoleman/exposing-polygontocells-containment
Feb 10, 2025
Merged

Exposing Experimental PolygonToCells and Updating to Master#68
zachcoleman merged 2 commits into
uber:masterfrom
zachcoleman:zcoleman/exposing-polygontocells-containment

Conversation

@zachcoleman

@zachcoleman zachcoleman commented Jun 18, 2024

Copy link
Copy Markdown
Collaborator

Leaving this open as a draft given these features are unreleased still by the core C library.

@zachcoleman zachcoleman mentioned this pull request Oct 10, 2024
Closed
@bert-huang-halter

bert-huang-halter commented Feb 10, 2025

Copy link
Copy Markdown

Hey @zachcoleman, given the new experimental stuff is in main now, could we get this in soon please?

@zachcoleman

zachcoleman commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator Author

Hey @zachcoleman, given the new experimental stuff is in main now, could we get this in soon please?

Sounds good, I will update this and get it released ASAP.

@zachcoleman zachcoleman force-pushed the zcoleman/exposing-polygontocells-containment branch from 85b1c92 to 2220f81 Compare February 10, 2025 16:20
@zachcoleman zachcoleman force-pushed the zcoleman/exposing-polygontocells-containment branch from 6fdc651 to b90df62 Compare February 10, 2025 17:24
@zachcoleman zachcoleman marked this pull request as ready for review February 10, 2025 17:57
@zachcoleman zachcoleman requested a review from jogly February 10, 2025 17:57
@zachcoleman
Adding Experimental PolygonToCells Features, Updating to Master, and …
ed5d99c 
…Test

changing module path

update test path

trying this?

adding CellsToMultiPolygon

fixing bad rebase thing

updating h3

clean up

updating h3

missed a file

adjusting to new api

updating to entire new h3 experimental api

linting

clean up
@zachcoleman zachcoleman force-pushed the zcoleman/exposing-polygontocells-containment branch from 085bbca to ed5d99c Compare February 10, 2025 17:59
jogly
jogly approved these changes Feb 10, 2025
View reviewed changes

@jogly jogly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zachcoleman zachcoleman merged commit 5f62a08 into uber:master Feb 10, 2025
@zachcoleman

zachcoleman commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator Author

Hey @zachcoleman, given the new experimental stuff is in main now, could we get this in soon please?

Done. Please refer to TestPolygonToCellsExperimental as an example. There's 2 flags exposed now: ContainmentMode and MaxNumCellsReturn (the second is new and from the C library). I have made MaxNumCellsReturn optional. If the number of cells from the query busts this number an error is returned.

Happy h3-ing and gophering.

@bert-huang-halter

bert-huang-halter commented Feb 10, 2025

Copy link
Copy Markdown

thank heaps for this!

@zachcoleman zachcoleman deleted the zcoleman/exposing-polygontocells-containment branch February 11, 2025 14:38
@coveralls

coveralls commented Feb 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 13247249870

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 19 of 21 (90.48%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 98.525%
Changes Missing Coverage Covered Lines Changed/Added Lines %
h3.go 19 21 90.48%
Totals Coverage Status
Change from base Build 12521357012: -0.3%
Covered Lines: 601
Relevant Lines: 610
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jogly jogly jogly approved these changes

@dfellis dfellis Awaiting requested review from dfellis

@ajfriend ajfriend Awaiting requested review from ajfriend

@isaacbrodsky isaacbrodsky Awaiting requested review from isaacbrodsky

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zachcoleman @bert-huang-halter @coveralls @jogly