Add error return codes to polygonToCells - #478
Merged
isaacbrodsky merged 6 commits intoAug 11, 2021
Merged
Conversation
isaacbrodsky
marked this pull request as ready for review
August 9, 2021 03:44
Collaborator
Author
|
@nrabinowitz @dfellis @ajfriend Please take a look, thanks! |
dfellis
approved these changes
Aug 9, 2021
dfellis
left a comment
Collaborator
There was a problem hiding this comment.
Very clean and clear PR :)
nrabinowitz
approved these changes
Aug 11, 2021
Co-authored-by: Nick Rabinowitz <public@nickrabinowitz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fairly straight forward, also added memory tests for
polygonToCells. While changing this, I noticed we should adjustmaxPolygonToCellsSizeto provide the size asint64_t. This also requires changes inpolygonToCells.