Add error returns to average area functions, etc#550
Merged
Conversation
added 7 commits
December 9, 2021 17:10
isaacbrodsky
commented
Dec 10, 2021
| } | ||
|
|
||
| double H3_EXPORT(getHexagonAreaAvgM2)(int res) { | ||
| H3Error H3_EXPORT(getHexagonAreaAvgM2)(int res, double *out) { |
Collaborator
Author
There was a problem hiding this comment.
This function - amongst possibly others - doesn't seem to have been renamed in the docs. We should check that functions have been renamed & all functions are listed in the docs with up to date signatures.
dfellis
approved these changes
Jan 3, 2022
ajfriend
approved these changes
Jan 3, 2022
nrabinowitz
approved these changes
Jan 3, 2022
| } | ||
|
|
||
| TEST(cell_area_invalid) { | ||
| H3Index invalid = 0xFFFFFFFFFFFFFFFF; |
Collaborator
There was a problem hiding this comment.
Nit: Maybe explain why you don't need a more comprehensive list of bad indexes (i.e. covered elsewhere)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.