The file CMakeTests.cmake is no longer included if ENABLE_TESTING is off#609
Merged
isaacbrodsky merged 3 commits intouber:masterfrom May 26, 2022
Merged
Conversation
dfellis
approved these changes
May 25, 2022
ajfriend
approved these changes
May 26, 2022
nrabinowitz
approved these changes
May 26, 2022
|
|
||
| ## [Unreleased] | ||
| ### Fixed | ||
| - Fix polyfill bug when vertex latitude exactly matches cell center. (#603) |
| option(BUILD_ALLOC_TESTS "Build tests for custom allocation functions" ON) | ||
| option(PRINT_TEST_FILES "Print which test files correspond to which tests" OFF) | ||
|
|
||
| include(TestWrapValgrind) |
Collaborator
There was a problem hiding this comment.
The visual diff here is lousy, but I assume from here on down it's just indentation changes?
Collaborator
Author
There was a problem hiding this comment.
Correct, there should be no substantive changes to this file. Reindenting in VS Code and comparing to master I see only a couple lines where indents differ but no other changes.
Collaborator
There was a problem hiding this comment.
You can tell github diff to ignore indentation and then it clears up here.
CMakeTests.txt is no longer included if ENABLE_TESTING is offCMakeTests.cmake is no longer included if ENABLE_TESTING is off
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick solution for uber/h3-py#239, but does not address the underlying issue of the file not being found. I do think this is useful because it allows us to unindent the
CMakeTests.cmakefile.Also fixed a missing CHANGELOG item for #603