Rename distance* functions to greatCircleDistance*#622
Conversation
| */ | ||
| /** @brief "great circle distance" between pairs of LatLng points in radians*/ | ||
| DECLSPEC double H3_EXPORT(distanceRads)(const LatLng *a, const LatLng *b); | ||
| DECLSPEC double H3_EXPORT(latLngDistanceRads)(const LatLng *a, const LatLng *b); |
There was a problem hiding this comment.
Please update the docs - API docs, upgrade instructions, and CHANGELOG.
There was a problem hiding this comment.
Done, thanks. When upgrading the docs I assumed that JS and Java would use latLngDistance and Python would use latlng_distance.
|
Sorry, I'm waffling on this, but I'm currently leaning toward
Too late to consider this version? |
|
I guess "haversine" isn't used in the the OGC names. Its ...but i don't think we're considering calling it |
Per offline discussion: The intent of this change is to disambiguate the point-to-point distance functions from the grid distance functions, particularly in binding contexts where the unit suffix may be lost.
This was just a straight search-and-replace, no other code changes.