Fix potential OOB read in localIjToCell#684
Merged
isaacbrodsky merged 1 commit intouber:masterfrom Sep 12, 2022
Merged
Conversation
nrabinowitz
approved these changes
Sep 12, 2022
dfellis
approved these changes
Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a potential out-of-bounds read in localIjToCell that can occur with a particular combination of base cell, resolution, and highly negative IJ coordinates. The coordinates were only being tested against positive bounds, which was incorrect. As the function that compares to unit vectors handles this already, that check is replaced with that call.