Add fuzzer discovered tests for polygonToCells#742
Add fuzzer discovered tests for polygonToCells#742isaacbrodsky wants to merge 2 commits intouber:masterfrom
Conversation
f8ed291 to
bcc7cc6
Compare
|
It feels to me like this is going to be a common case - the fuzzer finds uncovered code, or inputs that crash, and we want an easy way to replicate the fuzzer run in test. I don't think it's a great option to copy a bunch of the fuzzer code with small modifications for each fuzzer we want to replicate this way, but I can see there's no particularly easy way to add assertions to the fuzzer code (beyond "returns 0"). Some ideas:
I'm not sure what the best option is in C, but if we assume that "run fuzzer in test with a few basic assertions" is a common requirement, then we should design the fuzzers to make this simpler. |
I see two possibilities:
In general I'm not enthused about directly copying cases from the fuzzer except when they're very simple, because of the opacity and potential brittleness of the test. |
|
This PR is on hold after #785, as the new polygonToCells algorithm is slated to replace the old one. |
Adds test cases discovered via fuzzer for polygonToCells. These test cases hit some previously uncovered error cases.
These tests may be somewhat fragile because they aren't built specifically to trigger the offending behavior, but rather do so empirically. Subtle changes could result in the test cases no longer (or not in the first place) exercising the appropriate behavior.