Skip to content

Use CMAKE_INSTALL_LIBDIR#819

Merged
isaacbrodsky merged 1 commit intouber:masterfrom
kou:cmake-libdir
Feb 26, 2024
Merged

Use CMAKE_INSTALL_LIBDIR#819
isaacbrodsky merged 1 commit intouber:masterfrom
kou:cmake-libdir

Conversation

@kou
Copy link
Contributor

@kou kou commented Feb 26, 2024

We always use "lib" for library directory but Debian/Ubuntu use "lib/x86_64-linux-gnu" and RHEL use "lib64" on 64bit.

CMake provides CMAKE_INSTALL_LIBDIR that abstracts system library directory. We can use it by including GNUInstallDirs. See also: https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

We always use "lib" for library directory but Debian/Ubuntu use
"lib/x86_64-linux-gnu" and RHEL use "lib64" on 64bit.

CMake provides CMAKE_INSTALL_LIBDIR that abstracts system library
directory. We can use it by including GNUInstallDirs.
See also: https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html
@CLAassistant
Copy link

CLAassistant commented Feb 26, 2024

CLA assistant check
All committers have signed the CLA.

@kou
Copy link
Contributor Author

kou commented Feb 26, 2024

This will fix #406.

@coveralls
Copy link

Coverage Status

coverage: 98.827%. remained the same
when pulling 279e756 on kou:cmake-libdir
into a523fc6 on uber:master.

@isaacbrodsky isaacbrodsky merged commit 094699b into uber:master Feb 26, 2024
@kou kou deleted the cmake-libdir branch February 26, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants