Convert compactCells to use int64_t for indexing#920
Merged
isaacbrodsky merged 21 commits intouber:masterfrom Oct 17, 2024
Merged
Convert compactCells to use int64_t for indexing#920isaacbrodsky merged 21 commits intouber:masterfrom
isaacbrodsky merged 21 commits intouber:masterfrom
Conversation
dfellis
approved these changes
Oct 1, 2024
ajfriend
approved these changes
Oct 1, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #919, this converts the internal indexing to be 64 bit. This could be tested but needs a special setup since the memory requirements exceed small devices.