Conversation
isaacbrodsky
reviewed
Oct 7, 2024
Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
…s just going to quit milliseconds after it's finished processing the data and printing to the screen, so it's kinda painful here.
isaacbrodsky
reviewed
Oct 8, 2024
Collaborator
Author
|
I just ran this failure locally (set up CMAKE with the same configuration) and I can't reproduce it. @isaacbrodsky any idea what's going on here? EDIT: Resolved it myself by blowing away my |
Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
isaacbrodsky
approved these changes
Oct 14, 2024
Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
nrabinowitz
approved these changes
Oct 14, 2024
Collaborator
nrabinowitz
left a comment
There was a problem hiding this comment.
Left some comments, but overall this looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still as a draft because I've only hand tested some simple cases, and I know there's an issue with reading large polygon definitions from a file, but I wanted to get what I have up sooner rather than later so you can start taking a look at it.