CMake: Fix wrong MSVC related conditions#981
Merged
ajfriend merged 1 commit intouber:masterfrom Mar 7, 2025
Merged
Conversation
Fix uber#980 MSVC and GCC/Clang use different style for command line options. We should use "MSVC" not "WIN32" for detecting MSVC. If we use "WIN32", mingw-w64 also uses MSVC style command line options because "WIN32" is true for both of MSVC and mingw-w64.
Contributor
Author
|
I noticed that we have similar problems not only for |
dfellis
approved these changes
Mar 6, 2025
isaacbrodsky
approved these changes
Mar 6, 2025
ajfriend
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #980
MSVC and GCC/Clang use different style for command line options. We should use "MSVC" not "WIN32" for detecting MSVC. If we use "WIN32", mingw-w64 also uses MSVC style command line options because "WIN32" is true for both of MSVC and mingw-w64.