Skip to content

Add reverseDirectedEdge#1098

Merged
ajfriend merged 7 commits into
uber:masterfrom
ajfriend:aj/reverseDirectedEdge
Nov 29, 2025
Merged

Add reverseDirectedEdge#1098
ajfriend merged 7 commits into
uber:masterfrom
ajfriend:aj/reverseDirectedEdge

Conversation

@ajfriend

@ajfriend ajfriend commented Nov 26, 2025

Copy link
Copy Markdown
Collaborator

Closes #1076

  • function
  • tests
  • benchmark
  • docs
  • fuzz

@ajfriend

ajfriend commented Nov 26, 2025

Copy link
Copy Markdown
Collaborator Author

Separating this out because I was interested in comparing reverseDirectedEdge and directedEdgeToBoundary, since those are the two most expensive operations in my cellsToMultiPolygon implementation, so its useful to know how relatively expensive they are per edge.

On my laptop, I'm seeing that reverseDirectedEdge is usually about 12x faster:

./build/bin/benchmarkDirectedEdge
	-- directedEdgeToBoundary: 3.858900 microseconds per iteration (10000 iterations)
	-- reverseDirectedEdge: 0.305900 microseconds per iteration (10000 iterations)

@coveralls

coveralls commented Nov 26, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 98.949% (+0.003%) from 98.946%
when pulling 0942c42 on ajfriend:aj/reverseDirectedEdge
into ddf8844 on uber:master.

Comment thread src/h3lib/lib/directedEdge.c Outdated
@ajfriend ajfriend merged commit 312fbbc into uber:master Nov 29, 2025
45 checks passed
@ajfriend ajfriend deleted the aj/reverseDirectedEdge branch November 29, 2025 13:32
@ajfriend ajfriend mentioned this pull request Dec 1, 2025
6 tasks
@ajfriend ajfriend added this to the v4.5 milestone Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add reverse_directed_edge function

4 participants