Changes

• cellsToLinkedMultiPolygon now uses cellsToMultiPolygon internally (Add LinkedGeo <-> GeoMultiPolygon conversion functions #1126, Make cellsToLinkedMultiPolygon tests order independent #1133, Replace cellsToLinkedMultiPolygon backend with cellsToMultiPolygon #1136)
  • cellsToLinkedMultiPolygon (and cellsToMultiPolygon) now return errors for invalid cells (E_CELL_INVALID), mixed resolutions (E_RES_MISMATCH), and duplicate cells
    (E_DOMAIN) instead of producing undefined output
  • remove VertexGraph code
• destroyLinkedMultiPolygon is now idempotent (safe to call twice) (Replace cellsToLinkedMultiPolygon backend with cellsToMultiPolygon #1136)

Notes

• Changes should have full line and branch coverage. Overall % coverage goes down only because we deleted a bunch of files

Discussion

We should discuss the new invalid input behavior. We now raise errors instead of having undefined behavior on invalid, duplicate, or mixed resolution cells. Alternatively, we might automatically de-dupe for the user without raising an error, for example.

I'm in favor of the strict behavior; it helped us find one bug in the CLI recently with #1124.

Note that we can start strict and relax later without making a breaking API change. Relaxing an error into a success is backwards-compatible, but adding a new error to previously-accepted input is not. So strict is the safer starting point.

All that being said, it might be prudent to hold off on finalizing these APIs and releasing a new version until we implement uncompactCellsToMultiPolygon and #1114. Since we'll have a few functions with different expectations on inputs, it would be helpful to have them all in hand at once to figure out what the APIs should look like, and hopefully make them intelligible to end users.