Exclude an unreachable branch in polygonToCells->_getEdgeHexagons - #1208
Closed
isaacbrodsky wants to merge 1 commit into
Closed
Exclude an unreachable branch in polygonToCells->_getEdgeHexagons#1208isaacbrodsky wants to merge 1 commit into
isaacbrodsky wants to merge 1 commit into
Conversation
|
coverage: 99.719% (+0.02%) from 99.7% — isaacbrodsky:polygon-to-cells-coverage-3 into uber:master |
Collaborator
Author
|
Thanks fuzzers for proving this was not correct :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in the comment, I expect this is unreachable because the only cases where latLngToCell fails are: