Repository navigation
libcxxabi: Bump version to 21.1.8 and fix patches - #8
Open
CristianAndrei1423 wants to merge 1 commit into
Open
CristianAndrei1423 wants to merge 1 commit into
CristianAndrei1423 wants to merge 1 commit into
Conversation
Make both version selectable through menuconfig in Makefile.uk and Config.uk. When using new version, make it run with C++20 because of new keyword constinit. Change patches context means the old patch does not work with the new version. Make versioned sub-directories where each patch lives. Make them get selected with the coresponding version. Signed-off-by: Cristian Andrei <cristian.andrei1423@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the libcxxabi Unikraft library packaging to support selecting between LLVM upstream releases 14.0.6 and 21.1.8, and adjusts patching and build flags to accommodate the newer version.
Changes:
- Added a Kconfig
choiceto select between libcxxabi 14.0.6 and 21.1.8. - Updated the build to fetch/apply patches from versioned patch subdirectories.
- Added a C++ standard flag override for the 21.1.8 build.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| patches/21.1.8/0001-cxa_guard_impl_syscall.patch | Adds the 21.1.8-specific syscall-to-uk_syscall_static patch. |
| patches/14.0.6/0001-cxa_guard_impl_syscall.patch | Moves/updates the 14.0.6-specific syscall-to-uk_syscall_static patch into a versioned directory. |
| Makefile.uk | Selects libcxxabi version, updates patch directory to be version-specific, and adds a per-version C++ standard flag. |
| Config.uk | Introduces a menuconfig choice to select the libcxxabi upstream version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make both version selectable through menuconfig in
Makefile.ukandConfig.uk.When using new version, make it run with
C++23because of new keywordconstinit.Changed patch context means the old patch does not work with the new version. Make versioned sub-directories where each patch lives. Make them get selected with the corresponding version.
Tested functionalities through a minimal C++ app.
Depends-On: unikraft/unikraft#1832
Depends-On: unikraft/unikraft#1876
Depends-On: unikraft/unikraft#1875
Depends-On: unikraft/unikraft#1879
Depends-On: unikraft/unikraft#1856