Repository navigation
Conversation
Makefile.uk checks CONFIG_LIBUBSAN_SAN_DIV_BY_ZEOR, but Config.uk defines LIBUBSAN_SAN_DIV_BY_ZERO. Because of the typo, -fsanitize=integer-divide-by-zero is never added in custom mode, even when the option is enabled. Use the symbol name defined in Config.uk. Signed-off-by: Anand Prakash Srivastava <srivastavaanandprakash16@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #1946.
The config symbol for the integer division by zero check is misspelled in lib/ubsan/Makefile.uk (ZEOR instead of ZERO), so the flag is never added in custom mode. This changes it to the name defined in Config.uk.
Tested on QEMU (kvm) for x86_64 and arm64 with a small app that divides by a volatile zero:
Related Work
N/A
PR Checklist
checkpatch.ukon your commit series before opening this PR;