Skip to content

fix(interopDefault): avoid in operator for primitive inputs - #321

Merged
pi0 merged 2 commits into
mainfrom
fix/interop-mod-in
Oct 5, 2024
Merged

pi0 merged 2 commits into
mainfrom
fix/interop-mod-in

Conversation

@pi0

@pi0 pi0 commented Oct 5, 2024

Copy link
Copy Markdown
Member

resolves #319 (regression of #318)

If module export is a primitive like a number of string, in operator can throw an error.

Instead, we can simply make sure mod is an object or (extended) function. (null/undefined default is still checked in line after)

@pi0 pi0 self-assigned this Oct 5, 2024
@pi0 pi0 changed the title fix(interopDefault): avoid unnecessary in operator fix(interopDefault): avoid in operator for primitive inputs Oct 5, 2024
Comment thread src/utils.ts
Comment thread src/utils.ts
@pi0
pi0 merged commit 4be8bff into main Oct 5, 2024
@pi0
pi0 deleted the fix/interop-mod-in branch October 5, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot use 'in' operator to search for 'default' ...

2 participants