Repository navigation
Studio (AMD iGPU): split an iGPU row's total into VRAM and shared memory - #13421
danielhanchen wants to merge 3 commits into
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
for more information, see https://pre-commit.ci
Fixes #8942
What is wrong
On a Windows PC with an AMD graphics card and an AMD CPU with built-in graphics, Settings > System already splits the VRAM tile correctly since #9247:
The iGPU's own row under GPU devices still reads its whole 36.2 GiB as VRAM. The pill beside it says
VRAM(Unknown VRAMin the screenshot,4% VRAMonce #11871 fills in the used figure), and nothing on the row says that 34.2 GiB of that is system RAM. The reporter's screenshot on #8942 (RX 9070 XT + Radeon(TM) Graphics) shows exactly that. TheUnknownused figure on the same row was fixed separately by #11871.The fix
The row now uses the same split the tile uses (
gpuMemoryTotalsGb, applied to that one device):4% VRAM4%, with2 GiB VRAM + 34.2 GiB sharedon the line below21% VRAMX% VRAMX%, withShared with system RAMon the line belowThe total on the right stays 36.2 GiB, since that is what the iGPU can actually allocate; the row now says what it is made of. Rows for discrete cards and Vulkan iGPUs (which #11305 already shows as estimated availability) render as before. Display only: nothing about model fit, budgets or the backend changes, and the strings reused are the tile's own (
vramWithShared,sharedWithSystemRam), already translated in every locale.Tests
tests/resources-device-row-shared-split.test.ts, built from the #8942 readings (15.9 GiB card, iGPU 36.2 GiB total with 34.2 GiB host-backed):unified_memorywithoutshared_memory) reads as shared, as the tile doesresources-tab.tsxdropsVRAMfrom the pill and renders the split on its own line (beside the pill it truncatedGPU 1, ROCMat the dialog's width)Full frontend suite: 11761 / 11762 pass; the one failure (
account-permissions.test.ts, sandbox popup) is a load flake that passes alone on both main and this branch.npm run typecheckandnpm run i18n:check:strictclean; eslint on the touched files reports only the two errors already on main.What it looks like
Two isolated Studio installs, one built from the merge base
3075b73d1and one from head2d10282d9, driven by the same Playwright scene. This box has no AMD iGPU, so both installs were served thegpublock from #8942 (RX 9070 XT 15.9 GiB, Radeon(TM) Graphics 36.2 GiB with 34.2 GiB host-backed, used figures filled in as #11871 now does) by replacing only that block of/api/system; everything else is each install's own live reading.GPU 0, ROCM21% VRAM3.28 GiB used12.6 GiB free15.9 GiB totalGPU 1, ROCM4% VRAM1.5 GiB used34.7 GiB free36.2 GiB totalGPU 1, ROCM4%/2 GiB VRAM + 34.2 GiB shared1.5 GiB used34.7 GiB free36.2 GiB total4.78 GiB / 17.9 GiB VRAM + 34.2 GiB shared