Repository navigation
unsloth: repin Inkling onto b11534 for the chat API refactor - #258
Merged
Merged
Conversation
ggml-org#30210 (b11531) refactored the chat API: parsers assign build_chat_peg_parser() to data.parser directly and the template dispatch returns the init function. Inkling's parser now does both, so every base a run can pick from b11534 on compiles again.
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repins Inkling (ggml-org#25731) so the nightly compiles again.
ggml-org#30210 refactored the chat API in b11531:
build_chat_peg_parser(...)todata.parserdirectly instead of callingparser.save();common/chat.cppreturns the init function instead of calling it.Inkling's parser still used the old API, so every base a run can pick from b11534 on merges cleanly but does not compile (
common_peg_arena has no member named save). That is also why last night's run failed after #257.The Inkling branch now merges b11534 and makes the same two-line change upstream made to its own parsers. b11534 is the oldest tag a run can pick right now, so the pin carries no newer upstream commits onto it.
Verification
pin_contract.pyandmerge_checks.py: on b11534, b11535, b11537, b11538 and b11539, all 15 pins merge, all are intact, andmerge_checksis clean.test-chat: all tests pass, including Inkling's own parser cases onmodels/templates/Inkling.jinja.test-backend-ops:MUL_MAT2483/2483,MUL_MAT_ID940/940,PAD37/37,GET_ROWS216/216;feature_matrix.py --gpu: all 7 features pass on GPU.